Add support for dormakaba dKey locks#87501
Conversation
home-assistant
Bot
added
cla-signed
has-tests
new-integration
integration: dormakaba_dkey
labels
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Kane610
left a comment
Kane610
left a comment
There was a problem hiding this comment.
I don't know much about the bluetooth layers but the general implementation looks good!
| async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: | ||
| """Unload a config entry.""" | ||
| if unload_ok := await hass.config_entries.async_unload_platforms(entry, PLATFORMS): | ||
| data: DormakabaDkeyData = hass.data[DOMAIN].pop(entry.entry_id) |
There was a problem hiding this comment.
Observation: The naming throws me off here, data I would expect be some data description, not a class with connection properties.
There was a problem hiding this comment.
The class is a container of data which the integration stores in hass.data[], what would be a better name?
Maybe DkeyConfigEntryData?
emontnemery
force-pushed
the
dormakaba_dkey_mvp
branch
from
bf7337b to
65781a4
Compare
| """ | ||
| if self._async_in_progress(include_uninitialized=True): | ||
| return self.async_abort(reason="no_additional_devices_found") | ||
| return self.async_abort(reason="no_devices_found") |
There was a problem hiding this comment.
What if the discovery hasn't run yet? Then we should be able to force a discovery here, I think.
I don't think it's helpful for the user to just abort their effort to add the integration.
There was a problem hiding this comment.
There's no way to force a Bluetooth discovery, it runs continuously in the background.
I do agree the UX is not great, and I think that should be handled by improving the "add integration" dialog for bluetooth integrations which rely on Home Assistant's bluetooth discovery filter.
It could for example be updated so it shows a spinner + a text saying "Looking for compatible bluetooth devices", with the list of matching discovery flows updating while the dialog is open.
There was a problem hiding this comment.
I re-added the user flow for now so this integration is similar to other bluetooth integrations.
This reverts commit 0ef9d1c.
4 participants
Proposed change
Add support for dormakaba dKey locks
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: